New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration guide #940
Migration guide #940
Conversation
LGTM. I don't feel particularly strongly about the metadata functions being exported or not. Given they are currently, I'd be inclined to leave them that way to not surprise any RC users that might be using them somewhere. |
I think it is a very niche use-case, and now that we support all metadata keys described by AWS, the stuff re-exported from If you're happy with this and CI passes cleanly, feel free to hit merge. |
There are too many IMDS keys for it to be worth exporting them all from the root `Amazonka` module. Better to not do this at all than to leave it half-done. Also update the migration guide.
CI has passed. |
Fixes #939
Question: Is it still worth exporting
Amazonka.{dynamic,metadata,userdata}
from the top-level module, since the metadata interface is mainly for when you don't have anEnv
? We also only export the top level of IMDS keys, which seems silly.