Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide #940

Merged
merged 5 commits into from Jul 26, 2023
Merged

Migration guide #940

merged 5 commits into from Jul 26, 2023

Conversation

endgame
Copy link
Collaborator

@endgame endgame commented Jul 21, 2023

Fixes #939

Question: Is it still worth exporting Amazonka.{dynamic,metadata,userdata} from the top-level module, since the metadata interface is mainly for when you don't have an Env? We also only export the top level of IMDS keys, which seems silly.

@endgame endgame requested a review from brendanhay July 21, 2023 15:05
@endgame endgame added this to the 2.0 milestone Jul 21, 2023
@brendanhay
Copy link
Owner

LGTM. I don't feel particularly strongly about the metadata functions being exported or not. Given they are currently, I'd be inclined to leave them that way to not surprise any RC users that might be using them somewhere.

@endgame
Copy link
Collaborator Author

endgame commented Jul 23, 2023

LGTM. I don't feel particularly strongly about the metadata functions being exported or not. Given they are currently, I'd be inclined to leave them that way to not surprise any RC users that might be using them somewhere.

I think it is a very niche use-case, and now that we support all metadata keys described by AWS, the stuff re-exported from Amazonka doesn't cover anywhere near all of them. Also, those functions take an Env instead of a Manager, which is a bit weird. I made sure to call this change out in the migration guide.

If you're happy with this and CI passes cleanly, feel free to hit merge.

There are too many IMDS keys for it to be worth exporting them all
from the root `Amazonka` module. Better to not do this at all than to
leave it half-done.

Also update the migration guide.
@endgame
Copy link
Collaborator Author

endgame commented Jul 23, 2023

CI has passed.

@endgame endgame merged commit f3556c9 into brendanhay:main Jul 26, 2023
5 checks passed
@endgame endgame deleted the migration-guide branch July 26, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6.1 -> 2.0 Migration Guide
2 participants