Revert "Gen sorted interfaces" #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Data.Map.Map to sort gen outputs caused the ordering of certain fields inside the containers to change, breaking (at least)
amazonka-emr-containers. The generator tries to calculate the set of derivable typeclasses through aPtr, and takes a guess instead of looking up the actual pointed-to type.I have spent a week and a half trying to make this work, and have decided to give up. More fundamental changes are needed, and they can be done after 2.0. The bug is still present, but the relative ordering of
StructFvsPtrversions ofShapeFwithin aHashMaphasn't triggered any broken service bindings... yet.Reverts #862
Closes #880
Related to #888