Nostr Preferences #1186

sarthak13gupta · 2023-08-11T17:18:23Z

Nostr Screen for Creating a New Account / Importing Private Key.
Publishing User Defined Relays.
Added Primal(Nostr client).
Added support for Nip04 encrypt and decrypt operations.

…r_screen_check

…mments_platform

…ggle_comments_check

…upta/breezmobile into comments_platform

…into nostr_screen

…a/breezmobile into nostr_screen

…/breezmobile into nostr_screen

…zmobile into comments_login_logout

…/breezmobile into comments_platform

…into comments_platform

erdemyerebasmaz

Have some NIT comments.
I'll get into reviewing bloc logic & UI at a later time.

erdemyerebasmaz · 2023-08-11T18:44:04Z

lib/bloc/marketplace/marketplace_bloc.dart

+      var nostrSetttingsModel = NostrSettings.fromJson(settings);
+      _nostrSettingsController.add(nostrSetttingsModel.copyWith(
+        enableNostr: nostrSetttingsModel.enableNostr,
+        isRememberPubKey: nostrSetttingsModel.isRememberPubKey,
+        isRememberSignEvent: nostrSetttingsModel.isRememberSignEvent,
+        isLoggedIn: nostrSetttingsModel.isLoggedIn,
+        relayList: nostrSetttingsModel.relayList,
+      ));


Since we're not changing any of the NostrSettings values, we can add it directly as:

Suggested change

var nostrSetttingsModel = NostrSettings.fromJson(settings);

_nostrSettingsController.add(nostrSetttingsModel.copyWith(

enableNostr: nostrSetttingsModel.enableNostr,

isRememberPubKey: nostrSetttingsModel.isRememberPubKey,

isRememberSignEvent: nostrSetttingsModel.isRememberSignEvent,

isLoggedIn: nostrSetttingsModel.isLoggedIn,

relayList: nostrSetttingsModel.relayList,

));

_nostrSettingsController.add(NostrSettings.fromJson(settings));

erdemyerebasmaz · 2023-08-11T18:54:28Z

lib/bloc/nostr/nostr_bloc.dart

+  final defaultRelaysList = [
+    "wss://relay.damus.io",
+    "wss://nostr1.tunnelsats.com",
+    "wss://nostr-pub.wellorder.net",
+    "wss://relay.nostr.info",
+    "wss://nostr-relay.wlvs.space",
+    "wss://nostr.bitcoiner.social",
+    "wss://nostr-01.bolt.observer",
+    "wss://relayer.fiatjaf.com",
+  ];
+


Can't we read these from NostSettings? There should be one source of this list.

erdemyerebasmaz · 2023-08-11T18:58:18Z

lib/home_page.dart

+import 'bloc/marketplace/nostr_settings.dart';
+import 'bloc/nostr/nostr_actions.dart';


We're trying to avoid relative path imports as they are not git/refactor-friendly. Would you replace these and any other imports in the new files introduced to use absolute paths on imports?

sarthak13gupta · 2023-08-12T09:50:04Z

Will be working on these changes, also I found that the nip04 operations need a bit of correction, will do it in the upcoming commits.

roeierez

Thanks @sarthak13gupta !
Done initial pass. Dropped some comments and questions.
It seems to me that it will be easier to manage all nostr part in one bloc (NostrBloc) instead of splitting it into several blocs that depends on each other.
The marketplace bloc might depend on the NostrBloc (for the setting purposes).

roeierez · 2023-08-15T10:03:08Z

lib/bloc/marketplace/nostr_settings.dart

-          isRememberPubKey: false,
-          isRememberSignEvent: false,
+// start should be done by retrieving the values set in sharedPreferences
+  NostrSettings.start({


NIT: rename start to initial

roeierez · 2023-08-15T10:09:46Z

lib/home_page.dart

+    commentBloc.signEventStream.listen((event) async {
+      final nostrPrivateKey = widget.nostrBloc.nostrPrivateKey;
+
+      widget.nostrBloc.actionsSink.add(SignEvent(event, nostrPrivateKey));


It seems that it is more correct to not pass the private key to the SignEvent since the private key is already saved in the bloc.
All operations should not read (and pass) the private key which should be private field on the bloc and used there when needed.

Yes, will make the changes.

roeierez · 2023-08-15T10:13:15Z

lib/bloc/nostr/nostr_bloc.dart

@@ -39,6 +54,14 @@ class NostrBloc with AsyncActionsHandler {
    nostrPrivateKey = await _secureStorage.read(key: "nostrPrivateKey");


It seems that we are storing the private key in the golang library but read it from the secure storage. Can you explain that?

We are storing and fetching the private key in the golang library but only for the first time when a nostrBloc instance is made . Otherwise, if a new instance is made the private key is fetched from the secure storage(where it was stored the first time the key was created and fetched from the golang library).

If it is stored in the golang library why use secure storage at all?

okay got it, will remove the secure storage part.

roeierez · 2023-08-15T10:15:36Z

lib/bloc/nostr/nostr_model.dart

@@ -32,3 +14,29 @@ Map<int, String> eventKind = {
  10002: 'RelayList',
  30078: 'Application Specific Data'
 };
+
+Event mapToEvent(Map<String, dynamic> eventObject) {


NIT: in dart the best practice is to use toJson and fromJson

roeierez · 2023-08-15T10:24:42Z

lib/home_page.dart

@@ -127,6 +140,41 @@ class HomeState extends State<Home> with WidgetsBindingObserver {
      });
    });

+    commentBloc = Provider.of<NostrCommentBloc>(context, listen: false);


I don't see the NostrCommentBloc in the codebase. Did you forget to push?

It is a part of any time, you will find it here breez/anytime_podcast_player#48

roeierez · 2023-08-15T10:26:27Z

lib/home_page.dart

@@ -127,6 +140,41 @@ class HomeState extends State<Home> with WidgetsBindingObserver {
      });
    });

+    commentBloc = Provider.of<NostrCommentBloc>(context, listen: false);
+
+    widget.marketplaceBloc.nostrSettingsStream.listen((event) {


All these wiring between blocs should not be in the UI layer. More than that it indicates there it too much coupling between these blocs and maybe consider unify them to one NostrBloc. I need to see the NostrCommentBloc before I suggest anything.
If this is not an option we can always pass one bloc stream to another and this stream dependency can happen inside the bloc.

Actually, it is to connect the signevent method and getpubkey method of the nostrBloc to the nostrCommentBloc . It might not be the best place to do this, I wanted to be able to fetch both nostrBloc and nostrCommentBloc in one place to be able to connect them.

sarthak13gupta and others added 30 commits July 22, 2023 22:10

comments platform

ddcafa7

merge changes

4d1c991

toggle comments check

5062f78

adding nostr screen

cc0cdc8

Merge remote-tracking branch 'origin/toggle_comments_check' into nost…

2926867

…r_screen_check

nostr screen login/logout

4ddc46b

Merge branch 'master' of https://github.com/breez/breezmobile into co…

e93e05a

…mments_platform

Merge branch 'master' of https://github.com/breez/breezmobile into to…

ea79bd3

…ggle_comments_check

toggle comments changes

93a0761

Disable Nostr title corrected

5f7e0da

Merge branch 'toggle_comments_check' of https://github.com/sarthak13g…

87cffd5

…upta/breezmobile into comments_platform

anytime ref changes

610bed5

Merge branch 'master' of https://github.com/sarthak13gupta/breezmobile …

71ec1b8

…into nostr_screen

Merge branch 'nostr_screen_check' of https://github.com/sarthak13gupt…

1a66294

…a/breezmobile into nostr_screen

Merge branch 'comments_platform' of https://github.com/sarthak13gupta…

050959a

…/breezmobile into nostr_screen

Merge branch 'nostr_screen' of https://github.com/sarthak13gupta/bree…

69a2d14

…zmobile into comments_login_logout

anytime ref

a4e1dfb

Merge branch 'nostr_screen' of https://github.com/sarthak13gupta/bree…

c7df79c

…zmobile into comments_login_logout

login via comments platform

7d180ca

login from snort

2896791

Merge branch 'master' into comments_platform

00768ff

added primal and publishing relays

d129527

merge changes

3cb85da

previous primal logo removed

0b5c827

commentsBloc -> NostrCommentBloc

9100324

Merge branch 'comments_platform' of https://github.com/sarthak13gupta…

111cba4

…/breezmobile into comments_platform

Merge branch 'master' of https://github.com/sarthak13gupta/breezmobile …

7c89fcb

…into comments_platform

nostr-connect

fece6dd

merge_conflicts

232c075

mobile scanner -> 3.3.0

a38365a

sarthak13gupta added 3 commits August 11, 2023 22:28

saving relays in preferences

8b06da9

anytime ref changes

36716be

removing unwanted comments

0a6682b

erdemyerebasmaz reviewed Aug 11, 2023

View reviewed changes

roeierez requested changes Aug 15, 2023

View reviewed changes

sarthak13gupta and others added 23 commits August 15, 2023 19:19

review changes part-1

e24e7a2

anytime ref changes

22e0afe

making nostrPrivateKey a private field in the NostrBloc class

f37483d

merge changes nostr_preferences

5cfabec

removing secure_storage

9b0b60f

LoginWithImportedNostrKey-> StoreNostrKey

032060e

moving nostrSettings inside nostrBloc (part-1)

bff6f67

moving nostrSettings inside nostrBloc (part-2) completed

43ee2e6

nip04 operations corrected

225aa13

nip04 operations corrected(nostrBloc)

f2d5954

injecting nostrComments from BreezMobile to Anytime(without toggling)

f898084

toggling comments added

40ed1d7

Merge branch 'master' into comments_platform

46fad4e

merge conflicts

5304183

aligning nostrComments with nostr_preferences

d8abd95

Merge branch 'master' into nostr_preferences

5019311

mobile_scanner 3.3.0 changes

d6413f7

nostr_preferences merge changes

7386fec

merge changes

0a59d5b

anytime ref and adding nostr preferences in the home_navigation_drawer

e046651

Merge branch 'master' into nostr_preferences

fe0e4c1

Merge branch 'master' into nostr_preferences

945c696

Update dev.dart

7f9e329

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nostr Preferences #1186

Nostr Preferences #1186

sarthak13gupta commented Aug 11, 2023

erdemyerebasmaz left a comment

erdemyerebasmaz Aug 11, 2023

erdemyerebasmaz Aug 11, 2023

erdemyerebasmaz Aug 11, 2023 •

edited

sarthak13gupta commented Aug 12, 2023

roeierez left a comment

roeierez Aug 15, 2023

roeierez Aug 15, 2023

sarthak13gupta Aug 15, 2023

roeierez Aug 15, 2023

sarthak13gupta Aug 15, 2023

roeierez Aug 15, 2023

sarthak13gupta Aug 18, 2023

roeierez Aug 15, 2023

roeierez Aug 15, 2023

sarthak13gupta Aug 15, 2023

roeierez Aug 15, 2023

sarthak13gupta Aug 15, 2023 •

edited

		import 'bloc/marketplace/nostr_settings.dart';
		import 'bloc/nostr/nostr_actions.dart';

		@@ -39,6 +54,14 @@ class NostrBloc with AsyncActionsHandler {
		nostrPrivateKey = await _secureStorage.read(key: "nostrPrivateKey");

Nostr Preferences #1186

Are you sure you want to change the base?

Nostr Preferences #1186

Conversation

sarthak13gupta commented Aug 11, 2023

erdemyerebasmaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erdemyerebasmaz Aug 11, 2023 • edited

Choose a reason for hiding this comment

sarthak13gupta commented Aug 12, 2023

roeierez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarthak13gupta Aug 15, 2023 • edited

Choose a reason for hiding this comment

erdemyerebasmaz Aug 11, 2023 •

edited

sarthak13gupta Aug 15, 2023 •

edited