Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Code Guidelines

Brian Johnson edited this page Jun 15, 2017 · 9 revisions

UI

Refactoring

  • If you are moving/renaming files or methods as part of refactoring it should be done in a separate standalone PR before making other changes. This simplifies the changeset for reviewers and creates a relatively safe commit that can be pulled into other active branches.

Tests

Tests should be independent and work correctly when run individually or as a suite.

  • it blocks should only contain assertions and should not modify the DOM or app state.
  • it blocks should not be dependent on previous it blocks at the same depth. If you are testing a sequence of events use nested describe blocks example