Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated issue templates #38286

Merged
merged 11 commits into from
May 17, 2024
Merged

Updated issue templates #38286

merged 11 commits into from
May 17, 2024

Conversation

wknapik
Copy link
Contributor

@wknapik wknapik commented May 13, 2024

Everything can be adjusted, feel free to push to this PR branch, or request changes in comments

This can be tested at https://github.com/brave-experiments/wknapik-test-02/issues/new/choose

image

image

image

image

image

image

bsclifton and others added 4 commits May 15, 2024 16:10
This is intended for code health situations (Fixups for pull request,
refactorings, etc)

May need to make this a .yml - but wanted to try and see what happens.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tried it out and it's very nice

@iccub
Copy link

iccub commented May 17, 2024

Would be cool to have a Feature Request template. One text field and dropdown with a platform list ios,andro,desktop

@wknapik
Copy link
Contributor Author

wknapik commented May 17, 2024

@iccub I'd like to merge this without further delay, so I'm going to go ahead now. Please feel free to open a new PR for this. The change would consist of adding a file like .github/ISSUE_TEMPLATE/07_feature_request.yml (the number prefix would determine the order, 7 probably isn't the best), similar to the others, and the new template would automatically be featured on the list. I added you to the test repo wknapik-test-02, where you can test your changes by pushing to the main branch.

@wknapik wknapik merged commit ecb3747 into master May 17, 2024
4 checks passed
@wknapik wknapik deleted the wknapik-new-issue-templates branch May 17, 2024 17:34
@TEMP-ad
Copy link

TEMP-ad commented May 29, 2024

hey @wknapik wouldn't be good to add a specific Adblocking button as part of the templates as well? so people might post adblocking related issues in https://community.brave.com/c/support-and-troubleshooting/ad-blocking/ rather than GitHub?
That's where you see FanboyNZ checking adblocking issues mostly, and also other people try to help there, like Yuki2718. I used to do that too, but I am not in the forum anymore so can't help people there with custom rules and solutions.

Technically any filter list related issues should be in https://github.com/brave/adblock-lists/issues, but seems like community was made the better place for that.

The thing is that Brave depends mostly on other lists, so the issues that might happen because of Brave specific/made rules are minimal as well, but people might report them to brave anyway, when 3rd party default lists should be reported to the respective filter list repository/group that is causing the issue like Easylist or uAssets, or could be just a rule that will be updated/added by those groups later and Brave doesn't need to do anything and just wait for it like happens with youtube, although I know FanboyNZ/ryanbr might add it to Easylist, so reporting it from Community Brave can help to improve Easylist. But also issues might be a custom rule/list that people added or accidentally created themselves.

If anything, there is also Brave's Menu -> Help -> Report a broken site feature, which seems the better official/browser way to report adblocking and shield issues in general, but seems like Community with adblocking category is better (?).

I mean, look at the template made by uBlock people https://github.com/uBlockOrigin/uAssets/issues/new?assignees=&labels=&projects=&template=bug_report.yml just to try to avoid useless reports, this is because adblocking depends on so much that it needs really specific stuff to make sure it is a specific uBlock issue and not just random little big in a page or an extension causing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants