Include a Dockerfile and change configuration strategy to use a JSON file #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonshin - What do you think of this approach ? Full Disclosure, I am not a python dev. 😈 |
…it easier. Update README for Docker setup.
Moves from environment variables to a JSON config style.
bobbytables
changed the title
|
taking a look at it 👍 Thanks for the PR, making it easy to onboard is definitely a priority. I'll reach out to you to discuss a couple points before pulling it in |
|
@brandonshin - Looking forward to your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes around how configuration is loaded, pulling from the JSON file for everything.
This is done to enable Docker containerization easily. By mounting a config.json file in the container on start, and setting an ENV variable pointing to that file. We can easily load in configuration to the container on start.
We're using this fork at Namely right now and it's working great. Super easy to deploy.
@brandonshin - I'm happy to add you to the slackbots docker organization on hub.docker.com