Replace document.fonts.load with check #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document.fonts.load was failing to return. I think it may have to do with the resolution of promises but check works perfectly.
|
+1 also having this issue. It looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this lib in several projects and were getting a lot of timeouts for fonts that actually did load. After fixing several issues related to the handling of the returned promise I still found that in browsers that natively support the font loading API there were issues. After evaluating the code the most likely culprit appeared to be document.fonts.load. Replacing with check resolved our issues. However I wan only able to run our tests against the revised lib. When I ran
grunt testI got some errors about not being able to execute phatomJS. So you'll want to test this change.