Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Test on Python 3.11 #147

Closed
wants to merge 7 commits into from
Closed

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jan 30, 2023

Before submitting a pull request (PR), please read the contributing guide.

Description

Adds a test on Python 3.11.
Also fixes #146.

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@deprecated-napari-hub-preview-bot
Copy link

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/cellfinder-napari/147
Updated: 2023-01-30T18:04:24.105900

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 95.42% // Head: 95.42% // No change to project coverage 👍

Coverage data is based on head (510575a) compared to base (e2d73a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 510575a differs from pull request most recent head e7074be. Consider uploading reports for the commit e7074be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     brainglobe/cellfinder-core#147   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          17       17           
  Lines         808      808           
=======================================
  Hits          771      771           
  Misses         37       37           
Impacted Files Coverage Δ
cellfinder_napari/detect/detect.py 93.44% <ø> (ø)
cellfinder_napari/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alessandrofelder
Copy link
Member

superseded by brainglobe/cellfinder#266

@dstansby dstansby deleted the test-platforms branch December 13, 2023 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on GitHub actions
2 participants