Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CI on both types of Mac #143

Merged
merged 1 commit into from Apr 30, 2024
Merged

run CI on both types of Mac #143

merged 1 commit into from Apr 30, 2024

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to run CI on both Intel and Silicon Macs.

What does this PR do?

This PR modifies the workflow file so that test and installation runs smoothly on both Mac architectures.

References

Partial solution to brainglobe/BrainGlobe#63

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (70f751e) to head (56fc95b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files          10       10           
  Lines         448      448           
=======================================
  Hits          439      439           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder requested a review from a team April 29, 2024 17:03
@alessandrofelder alessandrofelder marked this pull request as ready for review April 29, 2024 17:03
@willGraham01 willGraham01 merged commit 4ebd237 into main Apr 30, 2024
13 checks passed
@willGraham01 willGraham01 deleted the adapt-Mac-CI branch April 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants