Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make non-conda mac tests use intel chips #196

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented May 3, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Non-conda tests were failing due to macos-latest now being run on Silicon tests.

What does this PR do?
Makes non-conda tests use Intel macs for now, and explains this in comments in the workflow file.

References

Partial solution to brainglobe/BrainGlobe#63

Related to brainglobe/brainglobe.github.io#171

How has this PR been tested?

CI runs observed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • [n/a] The code has been tested locally
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder mentioned this pull request May 3, 2024
4 tasks
@alessandrofelder alessandrofelder marked this pull request as ready for review May 3, 2024 13:49
@alessandrofelder alessandrofelder requested a review from a team May 3, 2024 13:49
@alessandrofelder alessandrofelder self-assigned this May 3, 2024
@adamltyson adamltyson merged commit 4714ee9 into main May 3, 2024
14 checks passed
@adamltyson adamltyson deleted the run-CI-on-both-macs-2 branch May 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants