Client stats #124
Open
Client stats #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonsinth
commented
Sep 16, 2020
| @@ -30,7 +30,7 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| const testServer = "localhost:11211" | |||
| const testServer = "127.0.0.1:11211" | |||
There was a problem hiding this comment.
NB: I had to use this to connect to my loopback-only memcached (we don't typically want local services to bind to external interfaces). I can revert this line if you want, but thought it might actually be nice to include.
Closed
|
ping? I think I addressed all your feedback in the original PR :) |
|
This feature is useful, thanks for taking the time to add it. I hope it gets merged some day |
|
Hi @bradfitz , do you have any update if there's anything blocking this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bradfitz I noticed that the author of #63 closed their PR. I'm really hoping to get this landed, so I reworked it a bit, addressed your original comments, and added some test coverage.