Align detect_helper with log message change #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"unknown func " log message may change in future to "program of this type cannot use helper ". Corresponding kernel change: https://lore.kernel.org/all/20240325152210.377548-1-yatsenko@meta.com/
|
@mykyta5 Thanks for the update! Did this get merged into linus's tree yet or just bpf-next? |
just bpf-next. |
|
Maybe let's wait until it hits mainline / linus - Not sure if I'm being overly cautious (cc @ajor @viktormalik @danobi) |
Yeah, let's wait for the patch to be merged to Linus' tree. |
|
@jordalgo, @viktormalik Looks like it was pulled to Linus repo: torvalds/linux@786bf0e |
jordalgo
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"unknown func " log message, produced by BPF verifier may change in future to "program of this type cannot use helper ". Corresponding kernel change:
https://lore.kernel.org/all/20240325152210.377548-1-yatsenko@meta.com/