ci: Add clang-tidy job #2973
Draft
ci: Add clang-tidy job #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danobi
force-pushed
the
clang_tidy
branch
2 times, most recently
from
be7dc8b
to
3aa87a4
Compare
|
I'm thinking that rather than get fancy with the GH action, we should slowly allow-list lints into A script we maintain that can both |
Fixes the following warning:
/home/dxu/dev/bpftrace/src/ast/irbuilderbpf.cpp: In member function 'llvm::CallInst* bpftrace::ast::IRBuilderBPF::CreateGetNs(bpftrace::TimestampMode, const bpftrace::location&)':
/home/dxu/dev/bpftrace/src/ast/irbuilderbpf.cpp:1025:26: warning: 'fn' may be used uninitialized [-Wmaybe-uninitialized]
1025 | return CreateHelperCall(fn, gettime_func_type, {}, "get_ns", &loc);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dxu/dev/bpftrace/src/ast/irbuilderbpf.cpp:1003:23: note: 'fn' was declared here
1003 | libbpf::bpf_func_id fn;
| ^~
We get a lot (thousands) of warnings if we enable all checks. Not all checks are relevant. We should add more as we notice things.
This change places the devshell packages earlier in $PATH than the inherited ones. This is important when devshell packages shadow tools in other packages. More specifically, we want to use the nix-aware "wrapped" clang-tidy from clang-tools rather than the "dumb" clang-tidy from clang.
danobi
force-pushed
the
clang_tidy
branch
2 times, most recently
from
6ce3fa5
to
4bed243
Compare
This job runs clang tidy against the working directory. This closes bpftrace#2971.
Looks most like casting fixes with ranged-for-loop fix mixed in as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental job to enable clang-tidy. This action should only run against the changes made in the PR.
This closes #2971.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md