biostacks.bt: use tracepoints instead of kprobes #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makelinux
requested review from
ajor,
viktormalik,
danobi and
fbs
as code owners
|
The problem is that the block_io_start tracepoint is relative new and not widely available. |
danobi
reviewed
Dec 28, 2023
There was a problem hiding this comment.
Seems like there's already prior art in having a -kp variant of the tool.
So probably fine to continue.
CI failure looks legit (and is what @chenhengqi mentioned). I think
ci.yml needs to be updated to ignore testing that tool.
viktormalik
reviewed
Jan 3, 2024
There was a problem hiding this comment.
I'd prefer moving tools/biostacks-kp.bt to tools/old/biostacks.bt which is the way we currently maintain multiple versions of tools for different kernels.
That would also allow to easily resolve the CI issue by adding the tool into TOOLS_TEST_OLDVERSION for relevant CI jobs.
because since v5.17-rc1~116^2~83 function blk_account_io_start became static and can't be used as a kprobe. But block_io_start tracepoint is available only since v6.5-rc1~114^2~181. The original kprobe version is retained as old/biostacks.bt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because since v5.17-rc1~116^2~83 function blk_account_io_start became static and can't be used as a kprobe.
But block_io_start tracepoint is available only since v6.5-rc1
114^2181.The original kprobe version is retained as biostacks-kp.bt