AST: Various cleanups #2664

ajor · 2023-07-04T13:32:26Z

I'll wait for #2624 to go into master before I merge this, as there'll be conflicts.

Use move ctors for std::string and SizedType
Remove explicit keywords on multi-arg ctors (they were a hold-over from when the ctors were single-argument, before locations were added)
Use in-class initialisers instead of member initialisers for constants

- Use move ctors for std::string and SizedType - Remove explicit keywords on multi-arg ctors (they were a hold-over from when the ctors were single-argument, before locations were added) - Use in-class initialisers instead of member initialisers for constants

ajor · 2023-07-04T13:35:11Z

src/ast/ast.cpp

@@ -633,7 +618,7 @@ Map::Map(const Map &other) : Expression(other)
 }

 FieldAccess::FieldAccess(const FieldAccess &other)
-    : Expression(other), expr(nullptr)
+    : Expression(other) // TODO why not copy expr??


@fbs Do you remember if expr wasn't copied for a reason?

AST: Various cleanups

866fa6b

- Use move ctors for std::string and SizedType - Remove explicit keywords on multi-arg ctors (they were a hold-over from when the ctors were single-argument, before locations were added) - Use in-class initialisers instead of member initialisers for constants

ajor commented Jul 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AST: Various cleanups #2664

AST: Various cleanups #2664

ajor commented Jul 4, 2023

ajor Jul 4, 2023

fbs Jul 4, 2023

AST: Various cleanups #2664

Are you sure you want to change the base?

AST: Various cleanups #2664

Conversation

ajor commented Jul 4, 2023

ajor Jul 4, 2023

Choose a reason for hiding this comment

fbs Jul 4, 2023

Choose a reason for hiding this comment