-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate staging DB with fake data #1337
Conversation
99be8a3
to
50569a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
+ Coverage 85.15% 85.40% +0.25%
==========================================
Files 226 228 +2
Lines 20940 21306 +366
Branches 1588 1670 +82
==========================================
+ Hits 17832 18197 +365
Misses 3091 3091
- Partials 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
420c2c6
to
85c359f
Compare
d14a13d
to
82ffad1
Compare
53a3af0
to
ff2d863
Compare
ff2d863
to
70d871e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review passed
if box_state is not None: | ||
location.box_state = box_state | ||
location.is_donated = box_state == BoxState.Donated | ||
location.is_lost = box_state == BoxState.Lost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take out lost and scrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep it for consistency until the is_lost
and is_scrap
fields are removed from the locations table?
- no LOST nor SCRAP locations - more InStock and Donated locations
data_faking.py
init.sql
is updated such that it contains only the data generated by the Minimal, DemoUsers, and Cypress PHP scripts in https://github.com/boxwise/dropapp/tree/5ae4408163e963f479c6ea33788c7993c8f00be5/db/seedsFunctional test:
docker compose up --build webapp
thencurl 'http://localhost:5005/cron/reseed-db' -H 'x-appengine-cron: true'
Needs clarification: