-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL interface for products pt. 3 #1325
GraphQL interface for products pt. 3 #1325
Conversation
ba4b6af
to
959b719
Compare
4afca60
to
ee2a006
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
+ Coverage 85.15% 85.24% +0.09%
==========================================
Files 226 225 -1
Lines 20940 21015 +75
Branches 1588 1570 -18
==========================================
+ Hits 17832 17915 +83
- Misses 3091 3094 +3
+ Partials 17 6 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
82a1f8c
to
c72c0e7
Compare
c72c0e7
to
614afbf
Compare
back/boxtribute_server/graph_ql/definitions/protected/types.graphql
Outdated
Show resolved
Hide resolved
back/boxtribute_server/graph_ql/definitions/protected/mutations.graphql
Outdated
Show resolved
Hide resolved
- only include standard products of newest version - add optional filtering by base ID to include all standard products enabled for that base
…erface-for-products-part-III
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review passed
…erface-for-products-part-III
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review passed
b61bbc7
to
87a8a6b
Compare
Review guide
What's new?
StandardProduct
data model and the corresponding GraphQL typestandard_product:read
(for theview_inventory
action-based permission)Functional review
Only the
dev_coordinator@boxaid.org
user has the new RBP granted in Auth0.Notes/questions
standardProduct*
queries return a union type wrapping the actual resource and errorsstandardProducts
query? E.g. only the newest version, or filtering for certain versions?Refernces