-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python version to 3.12 #1303
base: master
Are you sure you want to change the base?
Conversation
9a73031
to
479852d
Compare
having issues with mypy, trying to resolve here |
479852d
to
2c5fd63
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1303 +/- ##
===========================================
- Coverage 99.22% 85.15% -14.07%
===========================================
Files 104 226 +122
Lines 3466 20926 +17460
Branches 365 1738 +1373
===========================================
+ Hits 3439 17819 +14380
- Misses 10 3092 +3082
+ Partials 17 15 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pylipp . I have gone through your PR and encountered an issue building the image on my MacBook M1 machine. To resolve it, I needed to add the following command to the Dockerfile to ensure the compiler and necessary libraries were available:
RUN apk add --no-cache build-base libffi-dev
Without this, I received the following error:
× Building wheel for cffi (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [48 lines of output]
No working compiler found, or bogus compiler options passed to
the compiler from Python's standard "distutils" module. See
the error messages above. Likely, the problem is not related
to CFFI but generic to the setup.py of any Python package that
tries to compile C code. (Hints: on OS/X 10.8, for errors about
-mno-fused-madd see http://stackoverflow.com/questions/22313407/
Otherwise, see https://wiki.python.org/moin/CompLangPython or
the IRC channel #python on irc.libera.chat.)
Trying to continue anyway. If you are trying to install CFFI from
a build done in a different context, you can ignore this warning.
Additionally, after a successful build, I encountered a CORS error when sending requests to the backend. Could you please investigate this issue and make the necessary changes to resolve it?
Access to fetch at 'http://localhost:5005/graphql' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
Thank you!
2c5fd63
to
f738bcf
Compare
@vahidbazzaz does this error also happen on current master? |
Signed-off-by: P M <10617122+pylipp@users.noreply.github.com>
@pylipp I have tested this, and it is working fine in the master branch. |
@vahidbazzaz I'm a bit puzzled because the only relevant code change is a single line, replacing a deprecated datetime function. The rest is all changes to config files, mostly for deployment. Is there any additional error information from the console of the |
@vahidbazzaz I wonder if we're running into something like https://stackoverflow.com/a/61045178/3865876 Anyways it would help a lot if you could copy the exact request the FE sends by copying it e.g. as a curl command. |
No description provided.