Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(threaded-replies): reload sidebar for filters #3426

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

karelee7
Copy link
Contributor

@karelee7 karelee7 commented Oct 3, 2023

Overview

  • Activity items in the preview sidebar are now being fetched via UAA when using the filter
  • Update existing unit tests and added new unit tests

Demo

Example flow of using the "Unresolved" filter:
Screenshot 2023-10-03 at 3 28 14 PM
Screenshot 2023-10-03 at 3 28 46 PM
Screenshot 2023-10-03 at 3 28 58 PM

Video demo of all filters:
https://github.com/box/box-ui-elements/assets/95440409/c934d82b-208e-492d-a591-94f9f6d8df34

Example of concurrent comment adding on the same file:
Logged in as User 1
Screenshot 2023-10-04 at 12 54 54 PM

Logged in and added comment as User 2
Screenshot 2023-10-04 at 12 55 12 PM

Apply "Unresolved" filter as User 1
Screenshot 2023-10-04 at 1 02 16 PM

@karelee7 karelee7 requested a review from a team as a code owner October 3, 2023 22:37
@karelee7 karelee7 requested a review from a team as a code owner October 24, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants