chore(fonts): update Lato fonts to point to 1.0.17 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jaknas
force-pushed
the
update-fonts-1.0.17
branch
from
e137541
to
10529f8
Compare
jstoffan
reviewed
Apr 25, 2024
src/common/BaseAnnotator.scss
Outdated
| @@ -2,14 +2,14 @@ | |||
| font-weight: normal; | |||
| font-family: 'Lato'; | |||
| font-style: normal; | |||
| src: local('Lato Regular'), local('Lato-Regular'), url('https://cdn01.boxcdn.net/fonts/1.0.2/lato/Lato-Regular.woff2') format('woff2'), url('https://cdn01.boxcdn.net/fonts/1.0.2/lato/Lato-Regular.woff') format('woff'); | |||
| src: local('Lato Regular'), local('Lato-Regular'), url('https://cdn01.boxcdn.net/fonts/1.0.17/lato/Lato-Regular.woff2') format('woff2'), url('https://cdn01.boxcdn.net/fonts/1.0.17/lato/Lato-Regular.woff') format('woff'); | |||
There was a problem hiding this comment.
Could we import fonts.scss from BUIE, instead? It'd be one fewer place to keep track of the version.
jaknas
force-pushed
the
update-fonts-1.0.17
branch
from
10529f8
to
3d28875
Compare
|
Cool. Let's wait until the BUIE PR merges so we can bump the version in one go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUIE PR: box/box-ui-elements#3499
The fonts files itself haven't changed.
Changing it to have parity with internal Box changes. This will cause the 1.0.2 fonts to not be downloaded, in favor of existing 1.0.17.