Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

include device name in BT advertisments #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielkucera
Copy link
Contributor

No description provided.

@bergzand
Copy link
Contributor

You're right that the name should be included in the advertisements.
If I shorten the name to something like "RIOT", my Gadgetbridge picks up the device just fine. The weird thing is that Linux seems to pick up the default name fine while Gadgetbridge does not detect the name.

The issue here is that the default device name in combination with the 128 bit UUID exceeds the max length of an advertisement. I'm afraid that with your current fix, the 128 bit UUID is no longer included in the advertisement, is this correct?

I'll check if extended advertisements can be used here to solve this issue.

@danielkucera
Copy link
Contributor Author

The issue here is that the default device name in combination with the 128 bit UUID exceeds the max length of an advertisement. I'm afraid that with your current fix, the 128 bit UUID is no longer included in the advertisement, is this correct?

I don't remember by hard but I think I have not seen the UUID in the advertisement. And even with this patch, my watch was detected by gadgetbridge instantly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants