Use vite to build library #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Not stale |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
macklinu
commented
May 5, 2024
| @@ -22,7 +29,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "start": "node scripts/start.js", | |||
| "build": "node scripts/build.js", | |||
| "build": "vite build", | |||
There was a problem hiding this comment.
Could also use a library like tsup if you'd prefer.
|
Not stale |
|
I could really use this all well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I was blocked from using this library in Remix (same issue as #76). I wasn't sure how to modify the existing build system to fix the issue, but switching to Vite could be a simpler way to build this library that isn't dependent on all of the create-react-app config. I ran the new build script (
vite build) and linked it to a project of mine, and now theAvatarcomponent renders as expected.Are you open to this as a fix? I'd be happy to swap the demo over to Vite as well and get rid of a bunch of CRA & webpack dependencies to simplify - let me know and I'll open a couple issues.
Thanks!