Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement full screen photo feature #123

Merged
merged 2 commits into from
May 21, 2024
Merged

Implement full screen photo feature #123

merged 2 commits into from
May 21, 2024

Conversation

wang-li
Copy link
Collaborator

@wang-li wang-li commented May 15, 2024

The possibility to see a topo photo in full screen mode and zoom on it has been available in the iOS app for a long time, but still was not implemented in the android app.

full-screen-photo.mp4

The image can be zoomed by a pinch gesture or by a double tap.

Also, in the case of a missing boulder problem (highly unlikely, as the full screen photo has to be accessed from the topo of an already existing boulder problem), the following message will be shown:

Resolves #21

@nmondollot
Copy link
Member

Looks good 👍

A few things:

  • when I dismiss the full screen photo the map screen flickers (the area bar gets blank, the map gets gray), can we avoid that?
  • is it possible to dismiss the full screen photo with a gesture? (or it is just on iPhone?)
  • zoom: is it possible to make the line thinner as we zoom (similar to iPhone)?

Also, in the case of a missing boulder problem (highly unlikely, as the full screen photo has to be accessed from the topo of an already existing boulder problem), the following message will be shown:

"Boulder problem" sounds weird, let's say "This photo can't be displayed"

@wang-li
Copy link
Collaborator Author

wang-li commented May 17, 2024

@nmondollot All your feedback are fixed ✌️

full-screen-photo.mp4

@nmondollot
Copy link
Member

Great!

@wang-li wang-li merged commit 57e017b into main May 21, 2024
@wang-li wang-li deleted the feat/full-screen-photo branch May 21, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full screen photo
2 participants