Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen photo #21

Closed
nmondollot opened this issue Jul 20, 2023 · 3 comments · Fixed by #123
Closed

Full screen photo #21

nmondollot opened this issue Jul 20, 2023 · 3 comments · Fixed by #123

Comments

@nmondollot
Copy link
Member

nmondollot commented Jul 20, 2023

When user taps on a topo photo, show a full-screen mode with pinch-to-zoom.

Note: when #19 is implemented, make sure that circles are easy to tap and doesn't not trigger the full-screen mode if the tap is a few pixels off.

Demo iOS

RPReplay_Final1689865652.MP4

Code iOS

https://github.com/boolder-org/boolder-ios/blob/main/Boolder/UI/Map/Problem%20details/Topo/TopoFullScreenView.swift

@nmondollot nmondollot added the enhancement New feature or request label Jul 21, 2023
@nmondollot nmondollot removed the enhancement New feature or request label Oct 29, 2023
@Novmbrain
Copy link

Novmbrain commented Mar 29, 2024

Hi!

I am a developer and bleausard. This project interests me a lot! I am keen on contributing to this project. Could you assign this issue to me?

I have some experience in Android Dev with Java. I've managed to build and run the Boulder app on my Android device and implement the spec "pinch to zoom the photo". However, I am not so clear about your workflow.

  • Do you use the Fork&Pull Request workflow
  • Before launching a Pull Request, do I need to run certain tests locally and how
  • Which kind of Code format rules should I respect

Looking forward to your reply.
@nmondollot
Best regard,

Wenjie

@nmondollot
Copy link
Member Author

Hello Wenjie,

Sorry for the late reply, I was on vacation.

Yes, you can open a PR!
Or publish your code somewhere else, it's fine. As long as we can see your code.

@wang-li is our lead developer, he will get back to you regarding the other questions!

@Novmbrain
Copy link

Hi, No worry. I have already forked the repo. I plan to implement the whole spec this week and create a PR for the first review. So glad to be able to contribute to an app that bleausards (include me) use daily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants