-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full screen photo #21
Comments
Hi! I am a developer and bleausard. This project interests me a lot! I am keen on contributing to this project. Could you assign this issue to me? I have some experience in Android Dev with Java. I've managed to build and run the Boulder app on my Android device and implement the spec "pinch to zoom the photo". However, I am not so clear about your workflow.
Looking forward to your reply. Wenjie |
Hello Wenjie, Sorry for the late reply, I was on vacation. Yes, you can open a PR! @wang-li is our lead developer, he will get back to you regarding the other questions! |
Hi, No worry. I have already forked the repo. I plan to implement the whole spec this week and create a PR for the first review. So glad to be able to contribute to an app that bleausards (include me) use daily |
When user taps on a topo photo, show a full-screen mode with pinch-to-zoom.
Note: when #19 is implemented, make sure that circles are easy to tap and doesn't not trigger the full-screen mode if the tap is a few pixels off.
Demo iOS
RPReplay_Final1689865652.MP4
Code iOS
https://github.com/boolder-org/boolder-ios/blob/main/Boolder/UI/Map/Problem%20details/Topo/TopoFullScreenView.swift
The text was updated successfully, but these errors were encountered: