Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track which Author/Work/Edition a duplicate has been merged into (mark) #3293

Closed
wants to merge 2 commits into from

Conversation

Minnozz
Copy link
Contributor

@Minnozz Minnozz commented Feb 22, 2024

Instead of deleting the duplicate, store a reference to the canonical entity.

  • Add merged_into field to BookDataModel
  • Move merging code from management command to BookDataModel
  • Change the delete into a "soft delete" that sets merged_into
  • Exclude merged entities from all queries, except when loading by ID
  • Redirect web requests to the canonical entity when a request for the duplicate entity is received
  • Return the correct ActivityPub response for a duplicate entity
  • Verify whether edition_rank still picks a good edition after merging Works
  • Find out what happens when a duplicate Edition contains spelling errors

First step towards solving #2898

@Minnozz Minnozz force-pushed the merge-into branch 3 times, most recently from 6a77b5d to 285490a Compare February 23, 2024 22:44
@Minnozz Minnozz changed the title Track which Author/Work/Edition a duplicate has been merged into Track which Author/Work/Edition a duplicate has been merged into (mark) Mar 1, 2024
@Minnozz
Copy link
Contributor Author

Minnozz commented Mar 5, 2024

Went for a different approach in #3299

@Minnozz Minnozz closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant