Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement flysystem #3454

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

praswicaksono
Copy link

@praswicaksono praswicaksono commented May 13, 2023

Q A
Branch master
Bugfix? no
New feature? yes
Deprecation? yes
Tickets? fix #1929

This PR will bump php to 8.0 in order to support flysystem v3

The approach are to mount every directory that available in filemanager and file-edit

  • Migrate FilemanagerController using FilesystemManager
  • Migrate FileEditController using FilesystemManager
  • Migrate ImageController using FilesystemManager

@praswicaksono praswicaksono marked this pull request as draft May 13, 2023 16:07
@praswicaksono praswicaksono marked this pull request as ready for review May 13, 2023 16:08
@praswicaksono praswicaksono changed the title [WIP] feat: initial works implementing flysystem [WIP] feat: implement flysystem May 13, 2023
@@ -4,7 +4,7 @@
"description": "🧿 Bolt 5 Core",
"license": "MIT",
"require": {
"php": ">=7.2.9",
"php": "^8.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump this in order to install flysystem v3

@praswicaksono praswicaksono changed the title [WIP] feat: implement flysystem feat: implement flysystem May 17, 2023
@markkasaboski
Copy link

markkasaboski commented Feb 14, 2024

@bobdenotter @praswicaksono What happened to this PR?

Ah, I see. Bob has passed https://twokings.nl/. I'm sure this probably happened a while ago, but only just recently found Bolt, so I'm just finding out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Flysystem
2 participants