Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the jsonb option to be able to update the mysql database #3281

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spomsoree
Copy link
Contributor

This fixed the problem described here: #1905 (comment)

I'm not able to test if fixtures can be installed with postgres. This may undo the fix made in the Issue above.

@bobdenotter
Copy link
Member

bobdenotter commented Aug 10, 2022

I'm looking into this PR, and i don't know quite enough about Postgres to judge it properly. .

About your comment, for what was breaking:

(sfsu is my alias to update the schema: sf doctrine:schema:update)
I run the following: sfsu --dump-sql && sfsu && sfsu --dump-sql:

To update the schema, I normally use bin/console doctrine:schema:update --force. Is that different than sf ?

@Spomsoree
Copy link
Contributor Author

Thats just a alias for php bin/console from the zsh symfony plugin: https://github.com/ohmyzsh/ohmyzsh/blob/master/plugins/symfony2/symfony2.plugin.zsh

It's exactly the same as php bin/console doctrine:schema:update --force

@Spomsoree
Copy link
Contributor Author

@bobdenotter As far as I know jsonb only improves the speed of the postgres database.

I just setup a postgres database, updated the schema, removed the jsonb option, generated migrations, which did result in an empty migrations file.

I think this should be safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants