Bugfix adding business time on a non-workday, after work hours #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want, e.g., 3 business days after Saturday at 7pm, that should be Thursday at 9am, not Friday at 9 am. This change preserves existing behaviour whereby, if we want 3 business days after Saturday at 11am, we will get Thursday at 11am. This seems counter-intuitive, but preserves backwards compatibility.
|
Thanks for the work. I'm merging #179 because it also take into account the before behavior. |
|
👍 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want, e.g., 3 business days after Saturday at 7pm, that should be Thursday at 9am, not Friday at 9 am.
This change preserves existing behaviour whereby, if we want 3 business days after Saturday at 11am, we will get Thursday at 11am. This seems slightly counter-intuitive, but preserves backwards compatibility.
Fixes #149
Happy to add more tests if desirable.