Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Ext css prefix used by namespaced builds #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsams
Copy link
Contributor

@nsams nsams commented Nov 5, 2013

This change is Reviewable

@bmoeskau
Copy link
Owner

bmoeskau commented Nov 6, 2013

Thanks for the PR. I can't merge it at the moment, since even though it only impacts the styles, it could be considered a "breaking" change if someone has customized their own styles using those CSS classes. Also, a few of the classes are actually specific to Extensible, so not sure that it makes sense to prefix those with Ext's base prefix. It would probably make sense to introduce an Extensible-specific prefix in code for Extensible styles, and I do have a task on my list to fully refactor the stylesheets (and convert to SASS) but not until 2.0. Anyway, I'll keep this PR open and come back to it later. Thanks.

@nsams
Copy link
Contributor Author

nsams commented Nov 7, 2013

do you have a roadmap/plan for 2.0?

@bmoeskau
Copy link
Owner

I have an internal road map that is subject to change, but I haven't yet announced anything publicly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants