Fix for the bug: [OPEN-342] Bug with single-click - reproducible in 1.5.1 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[OPEN-342] Bug with single-click - reproducible in 1.5.1 as posted in the forum at: http://ext.ensible.com/forum/viewtopic.php?f=3&t=634
[OPEN-342] Bug with single-click - reproducible in 1.5.1 as posted in the forum at: http://ext.ensible.com/forum/viewtopic.php?f=3&t=634 Implementation: Handling 'keyup' event (just ESC key) so event can be created with the next click after ESC is pressed by the user. Tested the following scenarios (on windows XP): 1) FF & Chrome -> Create event in basic.html sample after ESC key and with single click. Noticed the following: 1) In chrome, 'keypress' and 'keydown' events aren't triggered for ESC key, whereas in FF it is triggering.
Conflicts: src/calendar/view/AbstractCalendar.js
| @@ -22,7 +23,8 @@ Ext.define('Extensible.calendar.view.AbstractCalendar', { | |||
| 'Extensible.calendar.dd.DropZone', | |||
| 'Extensible.form.recurrence.RangeEditWindow' | |||
| ], | |||
|
|
|||
There was a problem hiding this comment.
Please discard whitespace-only changes prior to committing
|
Once you clean up these changes I'll merge the PR. |
…rovide a handler on: “eventdblclick” event
[OPEN-334] Month view: "+X more..." link missing. Details about the bug can be reviewed at: http://ext.ensible.com/forum/viewtopic.php?f=3&t=613&sid=9f1e63e3221d5e8bb110e99d2f4f3f5e Implementation is to recalculate the no of events to display when the month is changed. Steps to verify: in the current TestApp example, load the current month view for march 2013 it has all the test events. Click the < button to go to feb, then resize to make the browser smaller, then click > to go back to march, the + more links should be displayed properly (not hidden).
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OPEN-342] Bug with single-click - reproducible in 1.5.1
as posted in the forum at:
http://ext.ensible.com/forum/viewtopic.php?f=3&t=634
Implementation:
Handling 'keyup' event (just ESC key), so event can be created with the next click after ESC is pressed by the user when context menu is shown .
Tested the following scenarios (on windows XP):
Noticed the following:
This change is