Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click the status bar icon to index workspace. #1898

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tianyiw2013
Copy link

@tianyiw2013 tianyiw2013 commented Jul 29, 2021

Use status bar item instead of status bar message.
demo

@tianyiw2013
Copy link
Author

hi @bmewburn

@bmewburn
Copy link
Owner

bmewburn commented Dec 6, 2021

Hi @tianyiw2013 , thanks for the PR. I'm not sure about this, some users like to keep the status bar clear. It also might be confusing with the git sync controls. Would it be simpler to keybind the command if you wanted quick access to it?

@tianyiw2013
Copy link
Author

I didn't update the screenshot. In fact, the status bar displays "$(refresh) intelephense" by default.
If the user wants a clean status bar and doesn't need it, they can hide the status bar item.
In addition to setting shortcut keys, I think it's more convenient.

test

@tianyiw2013
Copy link
Author

I guess many people encounter abnormal indexing, but they don't know they can re index. So I think we can consider adding this button. When everyone encounters a problem, they may think that refreshing the index may solve some problems.

@Vincent-HD
Copy link

I agree with @tianyiw2013 , at first I didn't know there was a "index workspace" command, it would be cool to have it, since we can hide it, idk if it is really a problem. Maybe hiding it by default, but we loose the goal of it if so

@compilekaiten
Copy link

Will this be merged?

Seems like a great QoL addition!

@priyashpatil
Copy link

priyashpatil commented Sep 12, 2022

This is a must. I face indexing issues quite a lot of times. Sometimes need to restart the VSCode to get it properly working.

To the point from @bmewburn above in the thread. Yes, people like to keep the editor status bar clean. But along with this if we could have the option to trigger it using cmd+shift+p would be great.

@compilekaiten
Copy link

This is a must. I face indexing issues quite a lot of times. I had to restart the VSCode to get it properly working.

You can already trigger Indexing from the Command Palette...

A button would be nice though.

@priyashpatil
Copy link

What's the command for reindexing?

@tianyiw2013
Copy link
Author

@priyashpatil

What's the command for reindexing?

ctrl + shift + p > Index workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants