Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security updates #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Security updates #5

wants to merge 4 commits into from

Conversation

asd20752
Copy link

I have added some simple security updates with this pull.

  • Preventing SQL injection with binding parameters instead of hard coding into SQL string.
  • Checking if the requested database is a sub file of the working directory to prevent traversing of system folders.
  • Checking if the database exists before opening with SQL lite to prevent new empty files to be spawned.
  • Removed DEMO from README.md since they were broken anyways.

Added checking for backwards traversing of folders.
Also added checking if the database exsists. This to prevent the server from creating new databases when no file exsists.
Removed Demos from README since they were broken
@@ -2,22 +2,19 @@ PHP-MBTiles-Server
==================

### About
This is a fork of bmcbride's [PHP-MBTiles-Server](https://github.com/bmcbride/PHP-MBTiles-Server) work. With a few security updates.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree, was not aware that it would update in this repo. It was a change to my fork of the project. How can I revert this commit to this project, but keep it on my fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants