fix handle resolution in some cli commands #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
approved these changes
Apr 3, 2024
| @@ -78,7 +82,7 @@ var checkUserCmd = &cli.Command{ | |||
|
|
|||
| adminKey := cctx.String("admin-password") | |||
| xrpcc.AdminToken = &adminKey | |||
| xrpcc.Host = id.PDSEndpoint() | |||
| xrpcc.Host = cctx.String("admin-endpoint") | |||
There was a problem hiding this comment.
makes sense. at some point we should probably have a better name than "admin" but i'm not sure what that should be right now
There was a problem hiding this comment.
yeah, i always lean towards more verbose when i'm unsure here
| Host: "https://api.bsky.app", | ||
| Host: "https://mod.bsky.app", |
There was a problem hiding this comment.
would be good to have this be a config (env var) as well, but not a blocking issue
Comment on lines
-626
to
+631
| phr := &api.ProdHandleResolver{} | ||
| resp, err := phr.ResolveHandleToDid(ctx, did) | ||
| dir := identity.DefaultDirectory() | ||
| resp, err := dir.LookupHandle(ctx, syntax.Handle(did)) |
There was a problem hiding this comment.
feeling happy that these re-writes are basically one-to-one
There was a problem hiding this comment.
yeah, the only weird bit is i'm not using the parse handle code and am just casting direct to the handle type. Feels like unnecessary overhead to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably more of this to come, the ProdHandleResolver type is basically broken now