-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Audio not working in iOS 17 for UrlSource #1767
base: main
Are you sure you want to change the base?
Conversation
I can take a look, but I don't have a lot of time to spend on it, unfortunately. Do you know what is failing on your #1763 branch? It looks like the iOS tests are failing along with the macOS 14 ones? |
The thing is I tried to make data uris work on ios 16 and 17. And there I need two different sets of options. And in xcode for ios 16 the option for ios 17 is not recognized, although it is wrapped within
And macOS 14 is failing in the tests regardless of my changes. I guess we have to rebuild the ios/macos folder with the new flutter version and do a pod install to work properly. (Just a guess) |
There's a difference between testing for iOS 16 and building with an old version of XCode that only knows about iOS 16. To use the code wrapped in |
It looks like the GH actions macos-13 image has Xcode 15 installed, and also has both the iOS 16 and ios 17 SDKs, so using that should be sufficient: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md. You should be able to test the different iOS builds by just picking a different simulator. This stuff here is picking the device to run on: ```
|
Thank you for your help and the detailed answers!
The thing is, it passes several tests, but not the others. So this is unlikely to be a signing problem, I think: I vaguely remember to change the app id or team id to some random one in order to work locally:
Yeah that's what I thought, too.
But it seems, that I have to build with xcode 15, and then somehow run on XCode 14 in order to get the required iOS version 16. 16 is not available on XCode 15 (macOS 13).
Thank you :) That's what I actually tried here, but fails, because ios 16 is not available in that XCode version. |
16 is not available by default on Xcode 15, but it is installable. That GH page I linked to implied that a number of SDKs are installed on the macos-13 image, including both the 16 and 17 ones. If I get time I can try a few experiments but you should be able to install and run with the iOS 16 SDK on Xcode 15. |
Ok thanks for your help. I appreciate it. I try to get it working ;D |
If I get some time, I will experiment and let you know what I come up with. |
I finally got ios 16 working, by switching with |
This is a re-tread of @andyshephard's PR #1728 (comment).
It looks like the tests are failing on that one (maybe just because linting is failing?), so I've recreated it in a place where I can potentially fix it.