Make sure ipydguuid is removed in data getter #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
remove_ipydguuid_column
branch
from
5c95940
to
d41ed9f
Compare
martinRenou
force-pushed
the
remove_ipydguuid_column
branch
2 times, most recently
from
a370e4d
to
a73ba8a
Compare
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
remove_ipydguuid_column
branch
from
a73ba8a
to
51bb439
Compare
|
@gaborbernat pretty please :D It would be great to make a patch release with this and other merged PRs |
|
Tests? |
|
I believe only visual regression tests can catch this as it was the front-end that was leaking a new dataframe column |
|
I will look into it |
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
remove_ipydguuid_column
branch
from
edc290b
to
de268b3
Compare
Signed-off-by: martinRenou <martin.renou@gmail.com>
|
Done! |
gaborbernat
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ipydatagrid <1.3, only the user dataframe columns would show up in the data accessor:
This has changed in ipydatagrid 1.3 and the internal "ipyguuid" column was leaking, this PR fixes it