DRAFT: Streaming Datagrid #498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
reviewed
Apr 9, 2024
|
I've tried this out on my dev machine and it works really well. I can help with the backend filtering/sorting if you wish, in this or a separate PR. |
|
Thanks a lot for the review!
💯 Feel free to push on my branch, I'm adding you as a collaborator on my fork |
martinRenou
commented
Apr 9, 2024
martinRenou
force-pushed
the
streaming
branch
3 times, most recently
from
698cc08
to
3595723
Compare
This was referenced Apr 15, 2024
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
+ Fix cases for "raw" buffers Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: martinRenou <martin.renou@gmail.com>
Signed-off-by: Ian Thomas <ianthomas23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new widget
StreamingDatagridwhich lazily requests data to the back-end upon scrolling/resizing the grid. It only requests data needed to render the current viewport.This is a very early draft for discussion, it requires more testing.
Screencast.from.2024-04-08.11-34-30.webm
Wish-list for this PR to be merge-able:
StreamingDatagrid, simply because the front-end does not have the whole dataset. We may want to provide the ability to do back-end filtering for the mainDatagridwidget too, but front-end filtering should stay the default to not break current applications.tickmethod to the Python API to allow the back-end to notify the front-end the data has changed