{172983130}: Tweaking oldfile list #4421
Conversation
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/532 tests failed ⚠.
The first 10 failing tests are:
schemalk_extralock_generated
schemalk
truncatesc_offline_generated
comdb2sys
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
| assert(klen <= *rlen); | ||
| assert(memcmp(key, *resume, klen) == 0); | ||
|
|
||
| if (*resume == NULL) { |
There was a problem hiding this comment.
if *resume is NULL would this be valid for memcmp in the line above?
There was a problem hiding this comment.
You're right! I modified the assert and removed the other assert which is no longer applicable. Thank you!
riverszhang89
force-pushed
the
oldlist
branch
4 times, most recently
from
657e132
to
564b32a
Compare
A few tweaks to the oldfile list logic to make it collect faster. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 10/534 tests failed ⚠.
The first 10 failing tests are:
sc_resume_logicalsc_generated
schemalk_extralock_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered
sc_lotsoftables
sc_lotsoftables_logicalsc_generated
truncatesc_offline_generated
comdb2sys
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
|
@chands10 Thanks for the review! |
A few tweaks to the oldfile list logic to make it collect faster.