workaround stock sqlite token count limit #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakash10292
force-pushed
the
aar_increasing_token_limit
branch
from
94a8606
to
ee4dbfe
Compare
roborivers
reviewed
May 1, 2024
morgando
previously approved these changes
May 2, 2024
…d Expr op field to u16 since we now have more than 255 tokens Signed-off-by: Aakash Arayambeth <aakash10292@gmail.com>
aakash10292
force-pushed
the
aar_increasing_token_limit
branch
from
ee4dbfe
to
739cece
Compare
roborivers
suggested changes
May 3, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/532 tests failed ⚠.
The first 10 failing tests are:
sc_resume
truncatesc
schemalk_extralock_generated
truncatesc_offline_generated
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
|
cdb2test May 2 22:45:23 2024 in-comdb2db aar_increasing_token_limit.R20240502.10 |
mponomar
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exclude token count check as we've hit stock sqlite limit. Also expand Expr.op field to u16 since we now have more than 255 tokens