{171428666}: column character encoding #4366
Open
+183
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
reviewed
Apr 18, 2024
riverszhang89
force-pushed
the
utf8_encoding
branch
from
e36af9f
to
1b7f975
Compare
roborivers
suggested changes
Apr 19, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 11/528 tests failed ⚠.
The first 10 failing tests are:
lostwrite [setup failure]
schemalk
auth_twofiles_generated
auth_queueodh_generated
auth
comdb2sys
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
sc_downgrade
truncatesc_offline_generated
riverszhang89
force-pushed
the
utf8_encoding
branch
from
1b7f975
to
3f45643
Compare
roborivers
reviewed
Apr 24, 2024
roborivers
suggested changes
Apr 24, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/529 tests failed ⚠.
The first 10 failing tests are:
schemalk_logicalsc_generated
schemalk_extralock_generated
schemalk
queuedb_rollover
truncatesc_offline_generated
A new `ENCODING` keyword is introduced in this patch, that specifies a character set for a column. Invalid character encoding will be rejected. So far only `"utf8"` and `NONE` are supported. This allows users to conveniently create an indexable utf8 cstring column. It's implemented as a check constraint using the `utf8_validate()` function. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
riverszhang89
force-pushed
the
utf8_encoding
branch
from
3f45643
to
f532fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
ENCODINGkeyword is introduced in this patch, that specifies a character set for a column. Invalid character encoding will be rejected. So far only"utf8"andNONEare supported.This allows users to conveniently create an indexable utf8 cstring column. It's implemented as a check constraint using the
utf8_validate()function.