Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests attempting to start db with invalid csc2 #4330

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mponomar
Copy link
Contributor

@mponomar mponomar commented Apr 3, 2024

No description provided.

Signed-off-by: Michael Ponomarenko <mponomarenko@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/524 tests failed ⚠.

The first 10 failing tests are:
queuedb_rollover
sc_repeated_updates_logicalsc_generated
selectv_timepart
truncatesc
truncatesc_offline_generated

@@ -1,2 +0,0 @@
table t1 t1.csc2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t1 is used in the test and has a valid schema. It looks like the test is failing now because there's no table t1. Did you mean to remove it?

Signed-off-by: Mark Hannum <mhannum72@gmail.com>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 3/525 tests failed ⚠.

The first 10 failing tests are:
queuedb_rollover_noroll1_generated
pmux_sqlite_memory_generated
truncatesc_offline_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants