2-phased commit #4303
Open
2-phased commit #4303
+10,591
−449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
reviewed
Mar 20, 2024
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ util/logmsg.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ berkdb/txn/txn_util.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ bdb/rep.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/osqlsession.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/disttxn.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/osqlblockproc.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/toblock.c @@
+ Please make sure that a mutex is unlocked before returning.
markhannum
force-pushed
the
twopc
branch
2 times, most recently
from
d802093
to
e3174e5
Compare
markhannum
force-pushed
the
twopc
branch
3 times, most recently
from
50dc01f
to
11c798b
Compare
roborivers
suggested changes
Apr 18, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 8/530 tests failed ⚠.
The first 10 failing tests are:
sc_resume_logicalsc_generated
sc_resume
schemalk_extralock_generated
queuedb_rollover_noroll1_generated
tunables
sc_downgrade
truncatesc_offline_generated
lkmgr_waitdie_generated
markhannum
force-pushed
the
twopc
branch
5 times, most recently
from
184c49d
to
eadffb5
Compare
Signed-off-by: Mark Hannum <mhannum72@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two phased commit