Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort on commit if this lockid previously received deadlock #4234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

Abort the master if it attempts to commit a transaction which has previously received a deadlock.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 377/520 tests failed ⚠.

The first 10 failing tests are:
sc_truncate_lockorder_generated
systable_locking
queuedb_rollover
yast_stat4scan_generated
yast
prepare
analyze_recover_deadlock
analyze_partial_index_off_generated
autoanalyze
analyze

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 9/520 tests failed ⚠.

The first 10 failing tests are:
delfile_block [setup failure]
sc_truncate_lockorder_generated
schemalk_extralock_generated
sc_transactional_rowlocks_generated
sc_transactional_logicalsc_generated
queuedb_rollover
prepare
lostwrite
truncatesc

@markhannum markhannum force-pushed the commitdl branch 2 times, most recently from 3202304 to 60af6be Compare February 27, 2024 19:26
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/520 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_timepart
sc_truncate_lockorder_generated
truncatesc
schemalk_extralock_generated
sc_transactional_rowlocks_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/520 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_timepart
sc_truncate_lockorder_generated
sc_truncate
systable_locking

@markhannum markhannum force-pushed the commitdl branch 2 times, most recently from 04f27b1 to c1718af Compare February 28, 2024 16:17
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/520 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
sc_timepart
sc_truncate
transchunk_manyins
sc_downgrade

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint check:

@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/521 tests failed ⚠.

The first 10 failing tests are:
sc_timepart_logicalsc_generated
schemalk
sc_transactional
queuedb_rollover_noroll1_generated
queuedb_rollover
sc_downgrade

@markhannum markhannum force-pushed the commitdl branch 7 times, most recently from ead9f0f to 42a1006 Compare March 5, 2024 14:02
Fix various deadlock-then-commit bugs

Add commit-after-deadlock test

Signed-off-by: Mark Hannum <mhannum72@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants