Allow bool #4214
Open
Allow bool #4214
+0
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Lint check:
@@ db/block_internal.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/handle_buf.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/sqlglue.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/osqlcomm.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/toblock.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/osqluprec.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ plugins/newsql/newsql.c @@
+ Please remove debugging statements, and replace fprintf/printf with logmsg.
@@ db/sqlglue.c @@
+ Please make sure that a mutex is unlocked before returning.
roborivers
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.
We may want a different way to remove bool in the future, but it shouldn't depend on machine class Signed-off-by: Mike Ponomarenko <mponomarenko@bloomberg.net>
|
/runtests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want a different way to remove bool in the future, but it shouldn't depend on machine class.