{173892112}: temptabl-ifying txnlist #4156
Open
+202
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recovery may run out of memory if there're too many txnid's to keep track of. This patch implements a temptable logic for txnlist that greatly reduces the memory footprint without sacrificing too much performance (partly because that log and bufferpool I/O would dominate performance in such a case). Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
riverszhang89
force-pushed
the
new_txnlist
branch
from
6411ba5
to
0c26d4a
Compare
|
Turning this on to run through RR & RM ... |
roborivers
reviewed
Jan 11, 2024
roborivers
suggested changes
Jan 11, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 7/511 tests failed ⚠.
The first 10 failing tests are:
sc_truncate_lockorder_generated
sc_transactional
queuedb_rollover_noroll1_generated
queuedb_rollover
prepare
ddl_no_csc2
tunables
|
Passing rm: |
Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
roborivers
reviewed
Jan 12, 2024
roborivers
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 3/511 tests failed ⚠.
The first 10 failing tests are:
queuedb_rollover
prepare
sp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovery may run out of memory if there're too many txnid's to keep track of. This patch implements a temptable logic for txnlist that greatly reduces the memory footprint without sacrificing too much performance (partly because that log and bufferpool I/O would dominate performance in such a case).