Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open 200 - Tabbed Open dialog #1179

Merged
merged 4 commits into from
May 28, 2024
Merged

Open 200 - Tabbed Open dialog #1179

merged 4 commits into from
May 28, 2024

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented May 9, 2024 •
edited

#1190

#Test
percy

@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 5f18327
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/664df957c2dc7a00085202fe
😎 Deploy Preview https://deploy-preview-1179--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 9, 2024 •
edited

✅ Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 5f18327
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/664df957f36de700087a959b
😎 Deploy Preview https://deploy-preview-1179--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich added the enhancement New feature or request label May 15, 2024
@OlegMoshkovich OlegMoshkovich self-assigned this May 15, 2024
@OlegMoshkovich OlegMoshkovich force-pushed the Versions-100--Open_dialog branch 3 times, most recently from 7bea512 to c2474ad Compare May 21, 2024 14:38
This was linked to issues May 21, 2024
Open 200: Tabbed Open dialog #1190
Open
Default to list of sample models #756
Closed
@OlegMoshkovich OlegMoshkovich changed the title Open Dialog Open 200 - Tabbed Open dialog May 21, 2024
@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review May 21, 2024 21:58
nickcastel50
nickcastel50 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlegMoshkovich OlegMoshkovich merged commit e9d04f1 into bldrs-ai:main May 28, 2024
10 checks passed
OlegMoshkovich added a commit that referenced this pull request May 28, 2024
@OlegMoshkovich
Revert "Open 200 - Tabbed Open dialog (#1179)"
2236c06 
This reverts commit e9d04f1.
@OlegMoshkovich OlegMoshkovich mentioned this pull request May 28, 2024
Merged
OlegMoshkovich added a commit that referenced this pull request May 28, 2024
@OlegMoshkovich
Revert "Open 200 - Tabbed Open dialog (#1179)" (#1193)
3c60194 
This reverts commit e9d04f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickcastel50 nickcastel50 nickcastel50 approved these changes

@pablo-mayrgundter pablo-mayrgundter Awaiting requested review from pablo-mayrgundter

Assignees

@OlegMoshkovich OlegMoshkovich

Labels
enhancement New feature or request
Projects
Open 100
Status: Done
Sprints
Status: Done
Milestone
Open 200: Tabbed Open dialog
Development

Successfully merging this pull request may close these issues.

Open 200: Tabbed Open dialog Default to list of sample models
2 participants
@OlegMoshkovich @nickcastel50