Adding an isEqual Method #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `TKStateMachine` tries to determine if it can fire an event, it does: ``` [tkEventInstance.states containsObject: self.currentState]; ``` If you haven't instantiated the current state with the exact `TKState` instance used when setting up the machine, this will always fail to fire events. This fixes that issue.
| if (!other || ![other isKindOfClass:[self class]]) { | ||
| return NO; | ||
| } | ||
| if ([self name] != [other name]) { |
There was a problem hiding this comment.
Shouldn’t this be a string comparison?
|
@blakewatters Fixed that comparison. Wasn't really using my brain on that one. |
| @@ -74,4 +74,20 @@ - (void)encodeWithCoder:(NSCoder *)aCoder | |||
| [aCoder encodeObject:self.name forKey:@"name"]; | |||
| } | |||
|
|
|||
| # pragma mark - isEqual | |||
| - (BOOL)isEqual:(id)other | |||
There was a problem hiding this comment.
When defining the isEqual: method, ou MUST also implement the hash method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
TKStateMachinetries to determine if it can fire an event, it does:If you haven't instantiated the current state with the exact
TKStateinstance used when setting up the machine, this will always fail to fire events.This fixes that issue.