Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tunein] Fix existing extractors and add playlist (closes #20252) #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blackjack4494
Copy link
Owner

@blackjack4494 blackjack4494 commented Sep 13, 2020

@bubbleguuum
Copy link

bubbleguuum commented Sep 14, 2020

I created a new PR that applies without conflict.

Note that the conflict was only caused by the files refering to the youtube_dl directory instead of now youtube_dlc
and the fix was to simply get the original PR as a patch file, edit it to replace all occurrences of youtube_dl/ by youtube_dlc/, and apply the patch with git am.

Not sure renaming the youtube_dl folder to youtube_dlc is a good idea for applying original PRs directly.

@blackjack4494
Copy link
Owner Author

Don't worry there wouldn't be a problem if the folder was still named without an 'c'. Git seems to be smart enough to automatically identify the minor name change. It's just github that is not able to (at least yet)

I gave it a try earlier and it didn't work for me directly. However the changes you made were good enough just needs a bit more tweaking. No clue whether I already created a branch. But I can show you what I mean then.
One problem or actually the main one was the proper id identification.
The test link could contain to different ids but both of these couldn't be used in making an api request you need the guideId which I started to extract by using regex.
Check it later if I haven't created any branch yet (believe I just have it locally yet). Can also ping you then.

@bubbleguuum
Copy link

bubbleguuum commented Sep 14, 2020

Note sure what you mean exactly in the second paragraph, but the PR works for extracting TuneIn stream metadata as JSON (with -J).
It doesn't work for downloading audio (does not handle the SHOUTcast stream properly) but I must admit I do not need this functionality so did not test it (until now).

@blackjack4494 blackjack4494 added this to Review in progress in Status Oct 18, 2020
@blackjack4494 blackjack4494 moved this from Review in progress to In progress in Status Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants