Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little filename tweaking #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sheerluck
Copy link

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

ability to almost have "|" "\" and "/" in filenames

@sheerluck
Copy link
Author

Python-3 tests are ok, python-2 tests are broken.
Who needs python-2 in 2020, right? :)

@blackjack4494
Copy link
Owner

Well the python2 tests should still work. There is still support for Python2.
You may want to look at unichr here.
Also I am not quite sure what are the benefits of this? 😄

@sheerluck
Copy link
Author

what are the benefits of this?

with my patch video https://www.youtube.com/watch?v=sZPC8TgLoNE will become
FOB⧸MCR⧸Evanescence - Centuries⧸Welcome To The Black Parade⧸Bring Me To Life (Mashup).-sZPC8TgLoNE.webm

@blackjack4494
Copy link
Owner

image
Is it really intended to have big slashes (big solidus)??

@sheerluck
Copy link
Author

Big slashes look great. At least beats '_'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants