New feature - Add basic support for JUnit reports #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolautruche
approved these changes
Oct 12, 2021
|
Thanks @scyzoryck ! |
iamluc
reviewed
Oct 15, 2021
Player/Console/PlayerCommand.php
Outdated
| @@ -60,6 +61,8 @@ protected function configure() | |||
| new InputOption('sandbox', '', InputOption::VALUE_NONE, 'Enable the sandbox mode', null), | |||
| new InputOption('ssl-no-verify', '', InputOption::VALUE_NONE, 'Disable SSL certificate verification', null), | |||
| new InputOption('blackfire-env', '', InputOption::VALUE_REQUIRED, 'The blackfire environment to use'), | |||
| new InputOption('junit', '', InputOption::VALUE_REQUIRED, 'Save output execution report as JUnit to file'), | |||
|
|
|||
There was a problem hiding this comment.
I think the description should mention that the value is the path to the file where the the output will be written.
There was a problem hiding this comment.
Code formatted, description improved.
| @@ -114,6 +118,10 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| if ($input->getOption('disable-internal-network')) { | |||
| $player->addExtension(new DisableInternalNetworkExtension()); | |||
| } | |||
| if ($junit) { | |||
| $junitExtension = new JUnitExtension(); | |||
There was a problem hiding this comment.
As the XML extension is currently not a requirement of the player, we should add a runtime check and display a nice warning/error message if the extension is missing.
There was a problem hiding this comment.
Check added in line 86.
scyzoryck
force-pushed
the
feature/junit-integration
branch
from
25401f9
to
ff841e7
Compare
iamluc
reviewed
Oct 21, 2021
scyzoryck
force-pushed
the
feature/junit-integration
branch
from
ff841e7
to
b286038
Compare
lolautruche
suggested changes
Oct 21, 2021
Co-authored-by: Jérôme Vieilledent <lolautruche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I would like to add some basic support for JUnit reports - that becomes a nice standard for the showing reports from tests in tools like gitlab or junit. Here is some MVP PR for the basic support to show basic information about failed or passed tests.
Supported features:
Result has been checked agains Jenkins schema.
Features that can be added in the future: