AMD compatibility & manual initialization #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? Can you please take a look @bjork24? |
|
Btw, this pull request made the difference for me. I ended up doing to fire stuff on load: Unison.util.initializeUnison();
// ... add event listeners
Unison.emit(Unison.fetch.now().name); |
|
It seems as if @bjork24 is not really maintaining this anymore. But I guess we can live with forks. |
Adding "off" method for unsubscribing to events
| node_modules | ||
| .DS_Store |
There was a problem hiding this comment.
Since .DS_Store is an environmental file, rather than a project file, you might want to add that into your global gitignore config instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have added some changes in my custom branch to support AMD loaders and to be able to initialize Unison "manually". The problem with the original implementation was, that if included it inside your own
DOMContentLoadedlistener, the event inside Unison never fires (since it fires once). I added the publicutil.initializeUnisonmethod which can be called manually and initializes Unison.Also, I added an
.editorconfigfile to support your syntax and made some format changes. Feel free to include this in your version.P.S. Unison should still be exposed to the global namespace, so I assume that your comments plugin still works. However, I wasn't able to test this. Also, I have not added a minified version since I wasn't sure which minifier you usually use for your releases.